Re: [PATCH v2 1/1] printk: add __printf attributes to internal functions

[Sergey Senozhatsky]

On (05/25/17 13:29), Petr Mladek wrote:
> On Wed 2017-05-24 07:49:50, Nicolas Iooss wrote:
> > When compiling with -Wsuggest-attribute=format, gcc complains that some
> > functions in kernel/printk/printk_safe.c transmit their argument to
> > printf-like functions without having a printf attribute. Silence these
> > warnings by adding relevant __printf attributes.
> > 
> > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>
> > Acked-by: Petr Mladek <pmladek@xxxxxxxx>
> > ---
> > v2: add __printf attribute to the definition of vprintk_nmi() which is
> > used when CONFIG_PRINTK_NMI is not defined.
> 
> Sergey, I believe that that your Reviewed-by is still valid even after
> this small update. Is that true, please?

sure. sorry about that!

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

	-ss