Re: [PATCH][net-next] qtnfmac: remove duplicated assignment to mac

From: Sergey Matyukevich
Date: Thu May 25 2017 - 09:56:45 EST


> mac is being assigned twice, remove redundant 2nd assignment.
>
> Detected by CoverityScan, CID#1437554 ("Incorrect expression")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> index fc0ce2c09097..e3c090008125 100644
> --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> @@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up)
> void qtnf_virtual_intf_cleanup(struct net_device *ndev)
> {
> struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
> - struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy);
> + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);

Thanks !

Acked-by: Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx>