Re: [PATCH v2] um: add dummy ioremap and iounmap functions
From: Richard Weinberger
Date: Thu May 25 2017 - 11:48:37 EST
Logan,
Am 25.05.2017 um 17:42 schrieb Logan Gunthorpe:
> The user mode architecture does not provide ioremap or iounmap, and
> because of this, the arch won't build when the functions are used in some
> core libraries.
Which ones are failing?
I thought we killed the problem by making CONFIG_COMPILE_TEST depend on !UML.
> I have designs to use these functions in scatterlist.c where they'd
> almost certainly never be called on the um architecture but it does need
> to compile. Thus, if the function is ever hit it returns NULL.
I was never a fan of that approach because in my opinion drivers should have
proper dependencies, including a dependency on HAS_IOMEM.
But I'll no longer block these attempts if we can get rid of tons of fallout
every kernel release.
Thanks,
//richard