Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings
From: Greg KH
Date: Thu May 25 2017 - 12:59:00 EST
On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor@xxxxxxx wrote:
> From: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
Your subject line is very odd, please use the 'v2' marking properly...
>
> Remove several unneeded #includes, forward
> declarations and fix several issues reported
> by checkpatch.pl --strict, such as:
> - kfree(NULL) is safe and check is not required
> - macro argument reuse may cause possible side effects
> - enclose macro params in parens to avoid precedence issues
> - coding style
These, as always, need to be broken up into one-patch-per-type-of-thing,
you have been in the staging tree long enough to know this :(
Please do this first, then we can consider the rest of the series...
thanks,
greg k-h