Re: [PATCH v3 0/5] net-next: stmmac: rework the speed selection

From: David Miller
Date: Thu May 25 2017 - 13:09:03 EST


From: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
Date: Wed, 24 May 2017 09:16:42 +0200

> The current stmmac_adjust_link() part which handle speed have
> some if (has_platform) code and my dwmac-sun8i will add more of them.
>
> So we need to handle better speed selection.
> Moreover the struct link member speed and port are hard to guess their
> purpose. And their unique usage are to be combined for writing speed.
>
> My first try was to create an adjust_link() in stmmac_ops but it duplicate some code
>
> The current solution is to have direct value for 10/100/1000 and a mask for them.
>
> The first 4 patchs fix some minor problem found in stmmac_adjust_link() and reported by Florian Fainelli in my previous serie.
> The last patch is the real work.
>
> This series is tested on cubieboard2 (dwmac1000) and opipc (dwmac-sun8i).

Series applied.