Re: [PATCH 0/20 V3] Misc cleanups for ipc

[Kees Cook]

On Thu, May 25, 2017 at 11:50 AM, Manfred Spraul
<manfred@xxxxxxxxxxxxxxxx> wrote:
> Hi all,
>
> Updated series. The series got longer, because I merged all patches
> from Kees.
>
> Main changes are:
> - sems[] instead of sem[0].
> - Immediately use BUILD_BUG_ON()
> - Immediately move the memset() to avoid crashing with SEM_UNDO.
> - Use rcu for every security_xx_free(), even if ipc_addid() was not
>   successful

This all looks great (excepting the accidental hunk migration). I like
the change to use call_rcu(), though I still think it's overkill. ;)

Thanks for integrating my changes!

-Kees

> @Andrew: Could you add them again to your tree?
>
> @Michael:
> Should we update man semctl(2)?
> Several years ago, I did a review and found that sem_ctime is only
> for Coherent the time of the last change...
>
> http://calculix-rpm.sourceforge.net/sysvsem.html
>
> --
>         Manfred



-- 
Kees Cook
Pixel Security