Re: [PATCH] perf annotate: process tracing data in pipe mode
From: David Carrillo-Cisneros
Date: Thu May 25 2017 - 18:11:46 EST
+Jiri
On Wed, May 17, 2017 at 5:19 PM, David Carrillo-Cisneros
<davidcc@xxxxxxxxxx> wrote:
> perf annotate was missing the handler for tracing data records.
>
> Prior to this patch we obtained "unhandled" records when piping
> trace events to perf annotate (using -D option to show the
> dump_printf messages in process_event_synth_tracing_data_stub):
>
> $ perf record -o - -e block:bio_free sleep 2 | perf annotate -D --stdio
> ...
> 0x78 [0xc]: PERF_RECORD_TRACING_DATA: unhandled!
> ...
>
> Signed-off-by: David Carrillo-Cisneros <davidcc@xxxxxxxxxx>
> ---
> tools/perf/builtin-annotate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
> index 7a5dc7e5c577..ce44edc30c71 100644
> --- a/tools/perf/builtin-annotate.c
> +++ b/tools/perf/builtin-annotate.c
> @@ -397,6 +397,7 @@ int cmd_annotate(int argc, const char **argv)
> .namespaces = perf_event__process_namespaces,
> .attr = perf_event__process_attr,
> .build_id = perf_event__process_build_id,
> + .tracing_data = perf_event__process_tracing_data,
> .ordered_events = true,
> .ordering_requires_timestamps = true,
> },
> --
> 2.13.0.303.g4ebf302169-goog
>