Re: linux-next: build warning after merge of the drivers-x86 tree

From: Stephen Rothwell
Date: Thu May 25 2017 - 19:34:52 EST


Hi Andy,

On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
>
> On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
> >>
> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
> >> static ssize_t touchpad_store(struct device *dev,
> >> ^
> >>
> >> Introduced by commit
> >>
> >> 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
> >
> >
> > Andy, you warned me about this and I had forgotten before I included it in next.
> >
> > Would you like to drop this change, or drop the touchpad_store function?
>
> I would go with Arnd's patch if he respins one addressing my comment.

Any progress on this?

--
Cheers,
Stephen Rothwell