Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal

From: Inki Dae
Date: Thu May 25 2017 - 21:07:51 EST




2017ë 05ì 26ì 10:02ì Hoegeun Kwon ì(ê) ì ê:
> Since bridge node is referenced during in the probe, it should be
> released on removal.
>
> Suggested-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@xxxxxxxxxxx>
> ---
> Hi Inki,
>
> This patch seems to have been forgotten... :)

Yeah, forgot this. Merged.

Thanks,
Inki Dae

>
> Changes for V2:
>
> - Checked for rebase 4.12-rc2
>
> Best regards,
> Hoegeun
>
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 698a824..a11b795 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1805,6 +1805,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
>
> static int exynos_dsi_remove(struct platform_device *pdev)
> {
> + struct exynos_dsi *dsi = platform_get_drvdata(pdev);
> +
> + of_node_put(dsi->bridge_node);
> +
> pm_runtime_disable(&pdev->dev);
>
> component_del(&pdev->dev, &exynos_dsi_component_ops);
>