Re: [Intel-gfx] [PATCH v5 4/5] drm/i915/gvt: Dmabuf support for GVT-g

[Chris Wilson]

On Thu, May 25, 2017 at 02:28:25PM +0100, Chris Wilson wrote:
> On Tue, May 23, 2017 at 06:32:00PM +0800, Xiaoguang Chen wrote:
> > +	gtt_entries = (gen8_pte_t __iomem *)dev_priv->ggtt.gsm +
> > +		(fb_gma >> PAGE_SHIFT);
> > +	for_each_sg(st->sgl, sg, fb_size, i) {
> > +		sg->offset = 0;
> > +		sg->length = PAGE_SIZE;
> > +		sg_dma_address(sg) =
> > +			GEN8_DECODE_PTE(readq(&gtt_entries[i]));
> > +		sg_dma_len(sg) = PAGE_SIZE;
> 
> This assumes that the entries are PAGE_SIZE. This will not remain true.

Ok, we will only be supporting different page sizes for ppgtt. However,
it is probably better to use I915_GTT_PAGE_SIZE to match our insertions.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre