RE: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver (fwd)

From: Bogdan Purcareata
Date: Fri May 26 2017 - 10:35:32 EST


> -----Original Message-----
> From: Julia Lawall [mailto:julia.lawall@xxxxxxx]
> Sent: Friday, May 26, 2017 5:32 PM
> To: Bogdan Purcareata <bogdan.purcareata@xxxxxxx>
> Cc: andrew@xxxxxxx; f.fainelli@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kbuild-all@xxxxxx
> Subject: Re: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver (fwd)
>
> The u32 values on lines 73 and 79 will not be less than 0.

Will change to int for proper error checking.

Thanks!
Bogdan P.