Re: [PATCH v5 0/7] Add kselftest_harness.h

[Kees Cook]

On Fri, May 26, 2017 at 11:43 AM, MickaÃl SalaÃn <mic@xxxxxxxxxxx> wrote:
> Hi,
>
> This patch series make the seccomp/test_harness.h more generally available [1]
> and update the kselftest documentation in the Sphinx format. It also improve
> the Makefile of seccomp tests to take into account any kselftest_harness.h
> update.
>
> [1] https://lkml.kernel.org/r/CAGXu5j+8CVz8vL51DRYXqOY=xc3zuKFf=PTENe88XYHzFYidUQ@xxxxxxxxxxxxxx
>
> Regards,
>
> MickaÃl SalaÃn (7):
>   selftests: Make test_harness.h more generally available
>   selftests: Cosmetic renames in kselftest_harness.h
>   selftests/seccomp: Force rebuild according to dependencies
>   Documentation/dev-tools: Add kselftest
>   Documentation/dev-tools: Use reStructuredText markups for kselftest
>   selftests: Remove the TEST_API() wrapper from kselftest_harness.h
>   Documentation/dev-tools: Add kselftest_harness documentation

I think this series looks great; I've added my two remaining Acks.
Shuah, when you have time, please pull these into the selftest tree.
Thanks!

-Kees

>
>  Documentation/00-INDEX                             |   2 -
>  Documentation/dev-tools/index.rst                  |   1 +
>  .../{kselftest.txt => dev-tools/kselftest.rst}     | 101 ++-
>  MAINTAINERS                                        |   1 +
>  .../test_harness.h => kselftest_harness.h}         | 691 +++++++++++++--------
>  tools/testing/selftests/seccomp/Makefile           |   2 +
>  tools/testing/selftests/seccomp/seccomp_bpf.c      |   2 +-
>  7 files changed, 520 insertions(+), 280 deletions(-)
>  rename Documentation/{kselftest.txt => dev-tools/kselftest.rst} (52%)
>  rename tools/testing/selftests/{seccomp/test_harness.h => kselftest_harness.h} (52%)
>
> --
> 2.11.0
>



-- 
Kees Cook
Pixel Security