Re: [PATCH v2 0/4] Add iomux-route switching support

From: Heiko Stuebner
Date: Fri May 26 2017 - 21:26:59 EST


Hi David,

Am Freitag, 26. Mai 2017, 15:20:19 CEST schrieb David Wu:
> The rk3228, rk3328, rk3399 have an interesting new feature,
> some things like one specific uart can use multiple pins to
> output data, but control of that seems to be split. The actual
> pin config is identical for all pins - each needs to be configured
> to function 2.
>
> Use one pin of a specifc group to be set to its special pinmux function,
> then configure the corresponding routing bits. If the pinmux setting is
> wrong for that pin the ip block won't work correctly anyway.


the approach looks nice now, the whole series
Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>


Thanks
Heiko


> David Wu (4):
> pinctrl: rockchip: Add iomux-route switching support
> pinctrl: rockchip: Add iomux-route switching support for rk3228
> pinctrl: rockchip: Add iomux-route switching support for rk3328
> pinctrl: rockchip: Add iomux-route switching support for rk3399
>
> drivers/pinctrl/pinctrl-rockchip.c | 321 ++++++++++++++++++++++++++++++++++++-
> 1 file changed, 320 insertions(+), 1 deletion(-)
>
>