Re: [PATCH 1/2] nvme: Wait at least 6000ms before entering the deepest idle state

From: Andy Lutomirski
Date: Sat May 27 2017 - 12:08:51 EST


On Fri, May 26, 2017 at 1:52 AM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Wed, May 24, 2017 at 03:06:30PM -0700, Andy Lutomirski wrote:
>> This should at least make vendors less nervous about Linux's APST
>> policy. I'm not aware of any concrete bugs it would fix (although I
>> was hoping it would fix the Samsung/Dell quirk).
>>
>> Cc: stable@xxxxxxxxxxxxxxx # v4.11
>
> Just following a somewhat odd and arbitray policy from another driver
> that doesn't fix anything by itself certainly isn't stable material.

Fair enough. The Cc: stable should certainly be dropped.

>
> And to be honest I'm not sure what applying it will gain us at all.

I'd be fine with skipping this patch entirely at least until we find
some evidence that it solves a problem instead.