Re: [PATCH 05/10] gpio: mockup: improve the debugfs input sanitization

From: Andy Shevchenko
Date: Sat May 27 2017 - 12:45:52 EST


On Thu, May 25, 2017 at 11:33 AM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> We're currently only checking the first character of the input to the
> debugfs event files, so a string like '0sdfdsf' is valid and indicates
> a falling edge event.
>
> Be more strict and only allow '0', '1', '0\n' & '1\n'.

Why not to be so strict and use

kstrtobool_from_user();

instead?

--
With Best Regards,
Andy Shevchenko