Re: [PATCH v4] sgi-xp: Use designated initializers

[Christoph Hellwig]

On Sat, May 27, 2017 at 05:39:14PM -0700, Kees Cook wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. In this case, no initializers
> are needed (they can be NULL initialized and callers adjusted to check
> for NULL, which is more efficient than an indirect call).

I'd say this looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Until I noticed all this is unused, so we should just remove it
entirely.  I now remember the weird SGI excuse, but given that they
haven't managed to get their code upstream in more than 10 years there
is no valid reason at all to keep this around.