Re: [PATCH] scripts/gdb: make lx-dmesg command work (reliably)
From: Jan Kiszka
Date: Sun May 28 2017 - 12:30:21 EST
On 2017-05-27 16:01, Andy Shevchenko wrote:
> On Fri, May 26, 2017 at 2:12 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>> On 2017-05-26 13:04, Andrà Draszik wrote:
>
>>> + log_buf_addr = int(str(gdb.parse_and_eval("'printk.c'::log_buf")).split()[0], 16)
>>
>> Overlong line. Please stay pep8 compliant.
>
> What I heard from colleague of mine couple of years ago, they (their
> team) moved to 100 characters in Python scripts because of somehow
> stupid recommendations from last century.
Well, it happens to be in line with the kernel preference for C code. We
can discuss a different style when the kernel relaxes its own. ;)
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux