Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device

[Alan Cox]

On Sun, 28 May 2017 14:30:35 +0200
Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

> Do not call dev_warn with a NULL device, this silence the following 2
> warnings:
> 
> [   14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO
> [   14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO
> 
> We could switch to using pr_warn for dev == NULL instead, but as comments
> in the source indicate, the check for these 2 special gmin variables with
> a NULL device is a workaround for 2 specific evaluation boards, so
> completely silencing the missing warning for these actually is a good
> thing.

At which point real missing variables won't get reported so NAK. I think
the right fix is to make the offending callers pass

	subdev->dev

which if my understanding of the subdevices is correct should pass the
right valid device field from the atomisp.

Please also cc me if you are proposing patches this driver - and also
linux-media.

Alan