Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer

[Martin Blumenstingl]

Hi Paolo, Hi Jonathan,

On Sun, May 28, 2017 at 4:43 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On Sun, 28 May 2017 13:24:38 +0200
> Paolo Cretaro <paolocretaro@xxxxxxxxx> wrote:
>
>> Fix sparse warning: Using plain integer as NULL pointer
>>
>> Signed-off-by: Paolo Cretaro <paolocretaro@xxxxxxxxx>
> This looks fine to me, but ideally you should always try to include
> the driver author - particularly in the case of patches to a recent
> driver such as this one.
>
> To that end I've cc'd Martin.
thanks for spotting this (and providing a patch to fix it)
this looks good to me, so:
Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

if you can wait until next weekend then I can also test this on real hardware.

> Jonathan
>> ---
>>  drivers/iio/adc/meson_saradc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
>> index 81cd39a57fe3..fb3f67a9ae1f 100644
>> --- a/drivers/iio/adc/meson_saradc.c
>> +++ b/drivers/iio/adc/meson_saradc.c
>> @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev)
>>               if (!meson_sar_adc_get_fifo_count(indio_dev))
>>                       break;
>>
>> -             regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0);
>> +             regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL);
>>       }
>>  }
>>
>

Regards,
Martin