Re: [PATCH] ubifs: Add freeze support

From: Richard Weinberger
Date: Mon May 29 2017 - 04:42:49 EST


Hyunchul,

Am 29.05.2017 um 04:24 schrieb Hyunchul Lee:
>>> This is just broken. First ubifs should still properly propagate
>>> the errors, and second freezing/unfreezing read only file systems is
>>> perfectly valid,
>>
>> it is right.
>
> if updating TNC is failed, ubifs might become inconsistant and be switched to
> read-only mode. for example, when ubifs_jnl_update is called to create a file,
> if inserting a znode for new inode is failed, TNC has only a znode for
> new dentry. and this can be only recoverd by replay.
>
> is it required to fix this?

UBIFS is designed to be power-cut tolerant.
So, UBIFS must not corrupt in any case.

Which failure are you facing?

I have the feeling that you try to paper over some other issue. :-)

Thanks,
//richard