Re: [PATCH 1/3] pinctrl: samsung: Constify wakeup driver specific data

From: Linus Walleij
Date: Mon May 29 2017 - 05:34:56 EST


On Tue, May 23, 2017 at 8:41 PM, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> Static exynos_irq_chip structures, containing driver specific data, are
> referenced only through opaque data pointer in const of_device_id table.
> The contents of pointed memory (exynos_irq_chip structure itself) is
> then copied with kmemdup() during wakeup initialization so
> exynos_irq_chip can be made const for code safenes.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

All looks good to me, Acked-by.

Expecting to get this in a pull request.

Yours,
Linus Walleij