Re: [PATCH] reset: hisilicon: Fix hi6220 module license
From: Andreas FÃrber
Date: Mon May 29 2017 - 09:07:42 EST
Hi Philipp,
Am 29.05.2017 um 11:46 schrieb Philipp Zabel:
> On Thu, 2017-05-25 at 11:22 +0200, Andreas FÃrber wrote:
>> The hi6220_reset driver fails to load:
>>
>> [ 10.423640] hi6220_reset: module license 'unspecified' taints kernel.
>> [ 10.423644] Disabling lock debugging due to kernel taint
>> [ 10.423735] hi6220_reset: Unknown symbol regmap_write (err 0)
>> [ 10.423747] hi6220_reset: Unknown symbol devm_kmalloc (err 0)
>> [ 10.423759] hi6220_reset: Unknown symbol syscon_node_to_regmap (err 0)
>> [ 10.423768] hi6220_reset: Unknown symbol reset_controller_register (err 0)
>> [ 10.423784] hi6220_reset: Unknown symbol __platform_driver_register (err 0)
>>
>> Add a MODULE_LICENSE() to fix this.
>>
>> Fixes: 70b3590f639f ("reset: hi6220: fix modular build")
>> Cc: Arnd Bergmann <arnd@xxxxxxxx>
>> Cc: Chen Feng <puck.chen@xxxxxxxxxxxxx>
>> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
>> ---
>> drivers/reset/hisilicon/hi6220_reset.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
>> index 35ce53edabf9..d5e5229308f2 100644
>> --- a/drivers/reset/hisilicon/hi6220_reset.c
>> +++ b/drivers/reset/hisilicon/hi6220_reset.c
>> @@ -155,3 +155,5 @@ static int __init hi6220_reset_init(void)
>> }
>>
>> postcore_initcall(hi6220_reset_init);
>> +
>> +MODULE_LICENSE("GPL v2");
>
> Thank you, I have the same patch queued already.
Is your tree not integrated into linux-next? If so, please send Stephen
Rothwell an email to have that fixed.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)