Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames

[Namhyung Kim]

On Mon, May 29, 2017 at 08:36:25PM +0200, Milian Wolff wrote:
> On Mittwoch, 24. Mai 2017 17:02:37 CEST Namhyung Kim wrote:
> > On Wed, May 24, 2017 at 03:42:59PM +0200, Milian Wolff wrote:
> > > If you think the above is not a valid assessment, I'll try to change my
> > > patch series to use the IP + 1 trick you suggest. But I really don't
> > > think it's going to work.
> > 
> > So I agree that we should do symbol name comparison, but I still
> > prefer setting fake symbol address to [IP, +1].  That would reduce
> > memory space for annotate as well.
> 
> Can you expand on this? I can implement this, but without having a way to test 
> I don't know whether I'm doing it right or not ;-)
> 
> Note that fake symbols cannot be annotated from `perf report` currently. The 
> browser just does nothing - no error, nothing. So I'm really unsure how this 
> would influence the "memory space for annotate".

Hmm.. nevermind.  I missed that it cannot be annotated.  And if it
aggregates symbols by name, start address might not be necessary.

Thanks,
Namhyung