Re: [PATCH 06/15] mfd: atmel: use devm_of_platform_populate()

From: Lee Jones
Date: Tue May 30 2017 - 05:30:39 EST


On Mon, 29 May 2017, Benjamin Gaignard wrote:

> Use devm_of_platform_populate() to be sure that of_platform_depopulate
> is called when removing the driver.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
>
> CC: Lee Jones <lee.jones@xxxxxxxxxx>
> CC: linux-kernel@xxxxxxxxxxxxxxx
> ---
> drivers/mfd/atmel-flexcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index e8e67be..064bde9 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -80,7 +80,7 @@ static int atmel_flexcom_probe(struct platform_device *pdev)
>
> clk_disable_unprepare(clk);
>
> - return of_platform_populate(np, NULL, NULL, &pdev->dev);
> + return devm_of_platform_populate(&pdev->dev);
> }
>
> static const struct of_device_id atmel_flexcom_of_match[] = {

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog