Re: [PATCH] gpiolib: remove unused variable

[Andy Shevchenko]

On Tue, 2017-05-30 at 11:21 +0200, Arnd Bergmann wrote:
> This was left behind by a cleanup patch:
> 
> drivers/gpio/gpiolib.c: In function
> 'gpiochip_irqchip_init_valid_mask':
> drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' [-
> Werror=unused-variable]


Right, thanks for it!
Reviewed-by:ÂAndy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> 
> Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open
> coded loop")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> Âdrivers/gpio/gpiolib.c | 2 --
> Â1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index be8097097326..62ffb4e293d2 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const
> char *name)
> Â
> Âstatic int gpiochip_irqchip_init_valid_mask(struct gpio_chip
> *gpiochip)
> Â{
> -	int i;
> -
> Â	if (!gpiochip->irq_need_valid_mask)
> Â		return 0;
> Â

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy