Re: [PATCH 7/7] nvme: provide UUID value to userspace

From: Johannes Thumshirn
Date: Tue May 30 2017 - 06:23:11 EST

Next message: Gautham R Shenoy: "Re: [PATCH 1/6] powernv:idle: Correctly initialize core_idle_state_ptr"
Previous message: Joe Perches: "Re: [PATCH] ALSA: sound/core/pcm_timer.c: include pcm_local.h and remove some extraneous tabs"
In reply to: Christoph Hellwig: "Re: [PATCH 7/7] nvme: provide UUID value to userspace"
Next in thread: Johannes Thumshirn: "[PATCH 5/7] nvmet: implement namespace identify descriptor list"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 05/30/2017 11:30 AM, Christoph Hellwig wrote:
> Eww. This looks pretty sketchy and at least needs a good comment in
> the source. Maybe even a printk_ratelimited warning.

Comment sure, but do we really need a warning?

--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 NÃrnberg
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Next message: Gautham R Shenoy: "Re: [PATCH 1/6] powernv:idle: Correctly initialize core_idle_state_ptr"
Previous message: Joe Perches: "Re: [PATCH] ALSA: sound/core/pcm_timer.c: include pcm_local.h and remove some extraneous tabs"
In reply to: Christoph Hellwig: "Re: [PATCH 7/7] nvme: provide UUID value to userspace"
Next in thread: Johannes Thumshirn: "[PATCH 5/7] nvmet: implement namespace identify descriptor list"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]