Re: [PATCH] platform/x86: ideapad-laptop: Expose conservation mode switch

From: Hao Wei Tee
Date: Tue May 30 2017 - 10:05:14 EST


On 5/30/17 9:22 PM, Andy Shevchenko wrote:
> On Sun, May 28, 2017 at 4:47 PM, Hao Wei Tee <angelsl@xxxxxxxxxxx> wrote:
>> On 5/27/17 3:31 PM, Hao Wei Tee wrote:
>>> This exposes the battery conservation mode present on some (?) IdeaPads.
>>> The mode is set by calling ACPI method SBMC with argument 3 (on) or
>>> 5 (off). Status is reported in bit 5 of the return value of ACPI method
>>> GBMD.
>>>
>>> This patch was written based on an IdeaPad U430p. I'm not sure if the ACPI
>>> methods are the same across all IdeaPads, so it would be great if this got more
>>> testing across other models before it's merged.
>>
>> I got someone to test on an IdeaPad Y510p. It works on that too.
>
> Do we have any other option that expose something via sysfs?
>

Sorry, not sure what you meant.

If you meant

> Do we have any other options than expose something via sysfs?

I'm not sure, maybe an ioctl? That wouldn't be very convenient though.

The tp_smapi module (not in mainline) that exposes the battery threshold
functionality for ThinkPads also uses sysfs.

If you meant

> Do we have any other options that expose something via sysfs?

yes, camera_power, fan_mode, touchpad and conservation_mode.

Hao Wei