Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush

[Andy Shevchenko]

On Tue, May 30, 2017 at 10:17 PM, Jork Loeser <Jork.Loeser@xxxxxxxxxxxxx> wrote:

>> > +#define HV_FLUSH_ALL_PROCESSORS                        0x00000001
>> > +#define HV_FLUSH_ALL_VIRTUAL_ADDRESS_SPACES    0x00000002
>> > +#define HV_FLUSH_NON_GLOBAL_MAPPINGS_ONLY      0x00000004
>> > +#define HV_FLUSH_USE_EXTENDED_RANGE_FORMAT     0x00000008
>>
>> BIT() ?
>
> Certainly a matter of taste.

That's why ? is used, though slightly better to parse the BIT macros
which is also less error prone.

> Given that the Hyper-V spec lists these as hex numbers, I find the explicit numbers appropriate.

Yes, but since it introduces a full set of the flags I would not see
disadvantages by style.

-- 
With Best Regards,
Andy Shevchenko