Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv

From: Vivien Didelot
Date: Tue May 30 2017 - 15:58:05 EST


Hi Florian,

Florian Fainelli <f.fainelli@xxxxxxxxx> writes:

> I actually have a patch pending that adds support for HW
> insertion/extraction of switch tags (broadcom HW supports that) which
> require the orig_dev to be there so we know what features are supported
> by the master network device.

Is orig_dev really needed in the tagging implementation, or only in the
layer above? (dsa_slave_xmit and dsa_switch_rcv.)

> Do you mind dropping this one from your patch series?

I don't mind if they are actually needed in taggers. I'd wait for
reviews of the other patches before respinning though.

Thanks,

Vivien