Re: [HMM 06/15] mm/memory_hotplug: introduce add_pages

[Balbir Singh]

On Wed, 24 May 2017 13:20:15 -0400
JÃrÃme Glisse <jglisse@xxxxxxxxxx> wrote:

> From: Michal Hocko <mhocko@xxxxxxxx>
> 
> There are new users of memory hotplug emerging. Some of them require
> different subset of arch_add_memory. There are some which only require
> allocation of struct pages without mapping those pages to the kernel
> address space. We currently have __add_pages for that purpose. But this
> is rather lowlevel and not very suitable for the code outside of the
> memory hotplug. E.g. x86_64 wants to update max_pfn which should be
> done by the caller. Introduce add_pages() which should care about those
> details if they are needed. Each architecture should define its
> implementation and select CONFIG_ARCH_HAS_ADD_PAGES. All others use
> the currently existing __add_pages.
> 
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
> Signed-off-by: JÃrÃme Glisse <jglisse@xxxxxxxxxx>
> ---

Acked-by: Balbir Singh <bsingharora@xxxxxxxxx>

Looks good, from a CDM perspective, this means that HMM-CDM would continue
to use arch_add_memory()

Balbir Singh.