RE: [PATCH] tools/power x86_energy_perf_policy: fix resource leak on file descriptor

[Brown, Len]

Acked-by: Len Brown <len.brown@xxxxxxxxx>


-----Original Message-----
From: Colin King [mailto:colin.king@xxxxxxxxxxxxx] 
Sent: Wednesday, May 17, 2017 8:52 AM
To: Brown, Len <len.brown@xxxxxxxxx>
Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH] tools/power x86_energy_perf_policy: fix resource leak on file descriptor

From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Function get_pkg_num is leaking an open file, fix this with a fclose().

Detected with static analysis by cppcheck:
[tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:1115]:
   (error) Resource leak: fp

Fixes: 4beec1d7519691 ("tools/power x86_energy_perf_policy: support HWP.EPP")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
 tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
index 65bbe627a425..26a5b5265290 100644
--- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
+++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
@@ -1110,6 +1110,7 @@ unsigned int get_pkg_num(int cpu)
 
 	fp = fopen_or_die(pathname, "r");
 	retval = fscanf(fp, "%d\n", &pkg);
+	fclose(fp);
 	if (retval != 1)
 		errx(1, "%s: failed to parse", pathname);
 	return pkg;
-- 
2.11.0