Re: [PATCH v2] drm/pl111: fix warnings without CONFIG_ARM_AMBA

From: Eric Anholt
Date: Wed May 31 2017 - 14:27:53 EST


Arnd Bergmann <arnd@xxxxxxxx> writes:

> The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA,
> but it just causes needless warnings:
>
> drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable]
> drivers/gpu/drm/pl111/pl111_drv.c:81:12: error: 'pl111_modeset_init' defined but not used [-Werror=unused-function]
>
> This unhides the probe/remove functions again and just leaves the driver
> object as unused when CONFIG_ARM_AMBA is disabled, with a __maybe_unused
> annotation to shut up the warning.
>
> Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed and merged. Thanks!

Attachment: signature.asc
Description: PGP signature