Re: [PATCH v1 1/7] nvme: rename uuid to nguid in nvme_ns

[Christoph Hellwig]

On Wed, May 31, 2017 at 03:32:11PM +0200, Johannes Thumshirn wrote:
> The uuid field in the nvme_ns structure represents the nguid field
> from the identify namespace command. And as NVMe 1.3 introduced an
> UUID in the NVMe Namespace Identification Descriptor this will
> collide.
> 
> So rename the uuid to nguid to prevent any further
> confusion. Unfortunately we export the nguid to sysfs in the uuid
> sysfs attribute, but this can't be changed anymore without possibly
> breaking existing userspace.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>