Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

[Vivek Gautam]

Hi,

On Wed, May 31, 2017 at 7:53 PM, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>
> On 22/05/17 12:23, Vivek Gautam wrote:
>> Make use of reset_control_array_*() set of APIs to manage
>> an array of reset controllers available with the device.
>>
>> Cc: Jon Hunter <jonathanh@xxxxxxxxxx>
>> Cc: Thierry Reding <treding@xxxxxxxxxx>
>> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
>> Signed-off-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
>> ---
>>  drivers/soc/tegra/pmc.c | 91 +++++++++++++++++--------------------------------
>>  1 file changed, 31 insertions(+), 60 deletions(-)
>>
>> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
>> index e233dd5dcab3..668f5d3d3635 100644
>> --- a/drivers/soc/tegra/pmc.c
>> +++ b/drivers/soc/tegra/pmc.c
>> @@ -124,8 +124,8 @@ struct tegra_powergate {
>>       unsigned int id;
>>       struct clk **clks;
>>       unsigned int num_clks;
>> -     struct reset_control **resets;
>> -     unsigned int num_resets;
>> +     struct reset_control *reset;
>> +     struct reset_control_array *resets;
>
> It's a shame we can't avoid this additional reset pointer, but maybe
> there is no good alternative for now. So ...
>
> Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Tested-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Thanks for the testing and Ack.

Best regards
Vivek

>
> Cheers
> Jon
>
> --
> nvpublic
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project