Re: [PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables

From: Jean Delvare
Date: Thu Jun 01 2017 - 05:31:01 EST


On Wed, 17 May 2017 13:25:13 +0300, Mika Westerberg wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> Make sure dmi_system_id tables are NULL terminated.
>
> Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again")
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
> drivers/pinctrl/intel/pinctrl-cherryview.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index 2debba62fac9..e35d0fe4c737 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -1547,7 +1547,8 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"),
> DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"),
> },
> - }
> + },
> + {}
> };
>
> static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq)

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

This should go to stable trees IMHO.

--
Jean Delvare
SUSE L3 Support