Re: [RFC PATCH 10/10] x86/unwind: add undwarf unwinder

From: Josh Poimboeuf
Date: Thu Jun 01 2017 - 08:36:16 EST


On Thu, Jun 01, 2017 at 02:13:56PM +0200, Peter Zijlstra wrote:
> So we do that lookup for every single frame. That's going to hurt.
>
> Would it make sense to cache the last 'module' in an attempt to at least
> avoid that lookup again? Something like so:

The only thing with caching the module is, what if the module goes away?

Based on your previous comment I was thinking I would disable preemption
for the entire unwind_next_frame() step, but not *between* steps. I
suppose we could require the unwind caller to disable preemption but I'd
like to avoid that if possible.

--
Josh