Re: [REGRESSION] [4.11/4.12-rc3] Hang on Suspend to RAM

[Hugh Dickins]

On Thu, 1 Jun 2017, Martin Steigerwald wrote:

> Hello.
> 
> I live with that linux kernels since about 2-3 years at least or even longer 
> occasionally hang on hibernation to disk on this ThinkPad T520 with 
> Sandybridge. It happens so rarely and if usually leaves me without any easy 
> way to gather any debug information, that I just put up with it. The hang is 
> as follows: Power LED of ThinkPad T520 dims on and off like it does during a 
> hibernation or suspend cycle. Screen is black. And thats it. Sometimes it 
> eventually completed the process after a few minutes, but usually it is stuck 
> there for 10 minutes or more and I give up waiting then. Actually maybe even 
> it was with Nigel CunninghamÂs Tux On Ice when hibernation worked reliably. I 
> remember uptimes of 100-200 days for some old workstation and even my laptop 
> back then made 40 days or more. I never see this with any kind of somewhat 
> recent kernel on my current laptop.
> 
> Since 4.11 I have it quite often that a hang like this even happens on suspend 
> to RAM (standby) as well. And even quite often about 1 time of of 2-3 suspend 
> attempts. The hang symptoms are similar. Power LED dims on and off. Screen is 
> black.
> 
> Since this is my holidays and this again does not happen all of the time and 
> thus would be considerable effort to bisect, I think I am out here now. Unless 
> you have something I can test easily.
> 
> It seems I am much better off with opting out out of kernel testing as I tend 
> to usually get the nasty "I hang and I wonÂt tell you any hint as about why I 
> do so and do so only sometimes" kind of bugs that are too much effort for me 
> to provide any usable debug information about.
> 
> At least the most nasty i915 bugs in 4.9 and 4.10 seem to be gone meanwhile â 
> will close my reports about them today. So maybe I look back at 4.11 and 4.12 
> with ten or more stable releases. Seems current release candidates and even 
> releases by Linus are just to unstable for me to bear with. Which hints at a 
> lack of testingâ but then testing for me (and quite some others?) just seems 
> to be too much of an hassle and effortâ
> 
> so draw your own conclusions from there.
> 
> I still wanted to provide feedback on these quality issues, as no feedback can 
> easily be interpreted as "works correctly".
> 
> If you have any idea of useful information I can provide to you *easily* and 
> in a *short amount of time*, then feel free to share it. I have holidays 
> tough, so I am especially picky about the easily and short amount of time 
> part. 
> 
> Switching back to 4.10, last known working kernel, now.

The commit below reached Linus's tree a few hours ago, and fixes an i915
issue that several of us were seeing in 4.11 and 4.12-rc.  I didn't have
your symptoms - but I don't use hibernation: I think there's a good chance
that this commit will fix your issue (but I wouldn't be able help any
further if it does not work for you, sorry).

Depending on what tree you apply it to, it may not apply cleanly:
just delete the synchronize_rcu_expedited() and syncronize_rcu()
lines from that file.

Hugh

commit 4681ee21d62cfed4364e09ec50ee8e88185dd628
Author: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Date:   Thu May 18 11:49:39 2017 +0300

    drm/i915: Do not sync RCU during shrinking
    
    Due to the complex dependencies between workqueues and RCU, which
    are not easily detected by lockdep, do not synchronize RCU during
    shrinking.
    
    On low-on-memory systems (mem=1G for example), the RCU sync leads
    to all system workqueus freezing and unrelated lockdep splats are
    displayed according to reports. GIT bisecting done by J. R.
    Okajima points to the commit where RCU syncing was extended.
    
    RCU sync gains us very little benefit in real life scenarios
    where the amount of memory used by object backing storage is
    dominant over the metadata under RCU, so drop it altogether.
    
     " Yeeeaah, if core could just, go ahead and reclaim RCU
       queues, that'd be great. "
    
      - Chris Wilson, 2016 (0eafec6d3244)
    
    v2: More information to commit message.
    v3: Remove "grep _rcu_" escapee from i915_gem_shrink_all (Andrea)
    
    Fixes: c053b5a506d3 ("drm/i915: Don't call synchronize_rcu_expedited under struct_mutex")
    Suggested-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
    Reported-by: J. R. Okajima <hooanon05g@xxxxxxxxx>
    Signed-off-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
    Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
    Tested-by: Hugh Dickins <hughd@xxxxxxxxxx>
    Tested-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>
    Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
    Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
    Cc: J. R. Okajima <hooanon05g@xxxxxxxxx>
    Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx>
    Cc: Hugh Dickins <hughd@xxxxxxxxxx>
    Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
    Cc: <stable@xxxxxxxxxxxxxxx> # v4.11+
    (cherry picked from commit 73cc0b9aa9afa5ba65d92e46ded61d29430d72a4)
    Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
    Link: http://patchwork.freedesktop.org/patch/msgid/1495097379-573-1-git-send-email-joonas.lahtinen@xxxxxxxxxxxxxxx

diff --git a/drivers/gpu/drm/i915/i915_gem_shrinker.c b/drivers/gpu/drm/i915/i915_gem_shrinker.c
index 129ed303a6c4..57d9f7f4ef15 100644
--- a/drivers/gpu/drm/i915/i915_gem_shrinker.c
+++ b/drivers/gpu/drm/i915/i915_gem_shrinker.c
@@ -59,9 +59,6 @@ static void i915_gem_shrinker_unlock(struct drm_device *dev, bool unlock)
 		return;
 
 	mutex_unlock(&dev->struct_mutex);
-
-	/* expedite the RCU grace period to free some request slabs */
-	synchronize_rcu_expedited();
 }
 
 static bool any_vma_pinned(struct drm_i915_gem_object *obj)
@@ -274,8 +271,6 @@ unsigned long i915_gem_shrink_all(struct drm_i915_private *dev_priv)
 				I915_SHRINK_ACTIVE);
 	intel_runtime_pm_put(dev_priv);
 
-	synchronize_rcu(); /* wait for our earlier RCU delayed slab frees */
-
 	return freed;
 }