Re: [PATCH] tty: add TIOCGPTPEER ioctl

[Richard Henderson]

On 06/01/2017 01:00 PM, Aleksa Sarai wrote:
> > > --- a/arch/alpha/include/uapi/asm/ioctls.h
> > > +++ b/arch/alpha/include/uapi/asm/ioctls.h
> > > @@ -94,6 +94,7 @@
> > >   #define TIOCSRS485     _IOWR('T', 0x2F, struct serial_rs485)
> > >   #define TIOCGPTN       _IOR('T',0x30, unsigned int) /* Get Pty Number (of 
> > > pty-mux device) */
> > >   #define TIOCSPTLCK     _IOW('T',0x31, int)  /* Lock/unlock Pty */
> > > +#define TIOCGPTPEER    _IOR('T', 0x41, int) /* Safely open the slave */
> >
> > Shouldn't the list of definitions be kept sorted, by hex number?
> > (everywhere)
>
> Probably. The reason I put it here is because it logically is very similar to 
> TIOCGPTN and TIOSPTLCK, but I can move it if the hex order is more important 
> for maintainence.

Yes please.


r~