Re: [PATCH] net: phy: marvell: make two functions static

From: Colin Ian King
Date: Fri Jun 02 2017 - 10:04:15 EST


On 02/06/17 15:00, Andrew Lunn wrote:
> On Fri, Jun 02, 2017 at 12:14:24PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> functions m88e1510_get_temp_critical and m88e1510_get_temp_alarm can be
>> made static as they not need to be in global scope.
>>
>> Cleans up sparse warnings:
>> "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?"
>> "symbol 'm88e1510_get_temp_critical' was not declared. Should it be
>> static?"
>
> Hi Colin
>
> What about m88e1510_get_temp_alarm()? That should also have a static.

Ah, good point, I somehow missed that one. I'll send a V2

Colin
>
> Thanks
> Andrew
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>