Re: [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

From: David Miller
Date: Fri Jun 02 2017 - 14:14:53 EST


From: Jani Nikula <jani.nikula@xxxxxxxxx>
Date: Wed, 31 May 2017 18:50:43 +0300

> From: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>
> An error during suspend (e100e_pm_suspend),
...
> lead to complete failure:
...
> The unwind failures stems from commit 2800209994f8 ("e1000e: Refactor PM
> flows"), but it may be a later patch that introduced the non-recoverable
> behaviour.
>
> Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
> Cc: Dave Ertman <davidx.m.ertman@xxxxxxxxx>
> Cc: Bruce Allan <bruce.w.allan@xxxxxxxxx>
> Cc: intel-wired-lan@xxxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> [Jani: bikeshed repainted]
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Jeff, please make sure this gets submitted to me soon.

Thanks.