Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

From: Palmer Dabbelt
Date: Fri Jun 02 2017 - 23:32:36 EST


On Thu, 25 May 2017 10:05:05 PDT (-0700), pavel@xxxxxx wrote:
>> +static void ci_leaf_init(struct cacheinfo *this_leaf,
>> + struct device_node *node,
>> + enum cache_type type, unsigned int level)
>> +{
>> + this_leaf->of_node = node;
>> + this_leaf->level = level;
>> + this_leaf->type = type;
>> + this_leaf->physical_line_partition = 1; // not a sector cache
>> + this_leaf->attributes = CACHE_WRITE_BACK | CACHE_READ_ALLOCATE | CACHE_WRITE_ALLOCATE; // TODO: add to DTS
>> +}
>
> You may want to run the patches through checkpatch. (Comment style,
> long lines).

Thanks. Someone else suggested this and I've fixed most of the errors. I'll
submit a v2 with everyone's feedback once I get through my mail.