Re: [PATCH] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value

[Andy Shevchenko]

On Fri, Jun 2, 2017 at 5:58 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> The current comparison of entry < 0 will never be true since entry is an
> unsigned integer. Cast entry to an int to ensure -ve error return values
> from the call to jumbo_frm are correctly being caught.

>         if (unlikely(is_jumbo) && likely(priv->synopsys_id <
>                                          DWMAC_CORE_4_00)) {
>                 entry = priv->hw->mode->jumbo_frm(tx_q, skb, csum_insertion);
> -               if (unlikely(entry < 0))
> +               if (unlikely((int)entry < 0))

It feels like a hiding some other issue.

-- 
With Best Regards,
Andy Shevchenko