Re: [GIT PULL] Immutable branch between MFD, GPIO, Thermal and X86 due for the v4.13 merge window

[Darren Hart]

On Wed, May 31, 2017 at 03:33:48PM -0700, sathyanarayanan kuppuswamy wrote:
> Hi Lee,
> 
> 
> On 05/30/2017 11:57 PM, Lee Jones wrote:
> > On Tue, 30 May 2017, Sathyanarayanan Kuppuswamy Natarajan wrote:
> > 
> > > Hi All,
> > > 
> > > On Tue, May 30, 2017 at 8:38 PM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> > > > Hi all,
> > > > 
> > > > On Tue, 30 May 2017 09:53:06 +0100 Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> > > > > Dear fellow Maintainers,
> > > > > 
> > > > > Enjoy!
> > > > > 
> > > > > The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6:
> > > > > 
> > > > >    Linux 4.12-rc1 (2017-05-13 13:19:49 -0700)
> > > > > 
> > > > > are available in the git repository at:
> > > > > 
> > > > >    git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/ib-mfd-gpio-thermal-x86-v4.13
> > > > > 
> > > > > for you to fetch changes up to 6aa60f67c11c10540e43bbe5a6377f7a0231501e:
> > > > > 
> > > > >    platform: x86: intel_bxtwc_tmu: remove first level irq unmask (2017-05-30 09:34:08 +0100)
> > > > > 
> > > > > ----------------------------------------------------------------
> > > > > Immutable branch between MFD, GPIO, Thermal and X86 due for the v4.13 merge window
> > > > > 
> > > > > ----------------------------------------------------------------
> > > > > Kuppuswamy Sathyanarayanan (8):
> > > > >        mfd: intel_soc_pmic_bxtwc: Use chained irqs for second level irq chips
> > > > See my other bug report on this commit ...
> > > Sorry, its a mistake from my end. It looks like typec wcove driver got
> > > merged recently and I missed to add it to my cleanup patch set.
> > > 
> > > Lee,
> > > 
> > > I have created a patch to fix this issue.
> > > 
> > > Do you want me to send the entire series again with this fix or just
> > > send the fix alone.
> > This highlights the fact that this patch-set is not actually
> > bisectable.
> Except for the last patch set ( which has fix for typec driver compilation
> issue) that I sent yesterday,
> all other patch set versions are bisectable.
> 
> The problem was when I first created this patch set, typec wcove driver was
> not merged upstream.
> After creating the initial set, I was just improving the patch set and
> forgot to re-check for
> child devices that depend of PMIC MFD driver.  Thats why we came across this
> compilation issue.
> 
> In future, I will try to avoid these kind of issues. I think adding
> "allyesconfig" and "allmodconfig"
> compilation tests to my patch submit criteria should prevent these kind of
> issues.

We do this as well as 32 and 64b for the platform driver tree, I have found it
to be a reasonable sanity test.

-- 
Darren Hart
VMware Open Source Technology Center