Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups

[kgunda]

On 2017-06-03 00:01, Stephen Boyd wrote:
> On 06/01, kgunda@xxxxxxxxxxxxxx wrote:
> > On 2017-05-31 07:14, Stephen Boyd wrote:
> > >On 05/30, Kiran Gunda wrote:
> > >>diff --git a/drivers/spmi/spmi-pmic-arb.c
> > >>b/drivers/spmi/spmi-pmic-arb.c
> > >>index 7201611..6320f1f 100644
> > >>--- a/drivers/spmi/spmi-pmic-arb.c
> > >>+++ b/drivers/spmi/spmi-pmic-arb.c
> > >>@@ -657,42 +659,6 @@ struct spmi_pmic_arb_irq_spec {
> > >> 	unsigned irq:3;
> > >> };
> > >>
> > >>-static int search_mapping_table(struct spmi_pmic_arb *pa,
> > >>-				struct spmi_pmic_arb_irq_spec *spec,
> > >
> > >Perhaps the spec should be removed at some point if this was the
> > >only place it was passed to.
> > >
> > Yes. This is passed only in this function. You want to remove this
> > structure and pass the slave, per and irq as function parameters?
> > If so we will do it in the next patch.
>
> We don't pass it anywhere though? So I'm just saying have local
> variables instead of the structure.
Sure. Thanks for the clarification.