Re: [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback

[Archit Taneja]

On 05/30/2017 03:59 PM, Philipp Zabel wrote:
> Hi Archit,
>
> On Tue, 2017-05-30 at 15:54 +0530, Archit Taneja wrote:
> > Hi,
> >
> > On 05/25/2017 07:49 PM, Jose Abreu wrote:
> > > Now that we have a callback to check if bridge supports a given mode
> > > we can use it in Synopsys Designware HDMI bridge so that we restrict
> > > the number of probbed modes to the ones we can actually display.
> > >
> > > Also, there is no need to use mode_fixup() callback as mode_valid()
> > > will handle the mode validation.
> > >
> > > NOTE: Only compile tested
> > > NOTE 2: I also had to change the pdata declaration of mode_valid
> > > custom callback so that the passed modes are const. I also changed
> > > in the platforms I found. Not even compiled it though.
> >
> > This compiles fine and has been tested on Meson by Neil.
> >
> > Since this also touches rockchip/imx drm driver files, can I get an
> > OK from the maintainers to pull the changes via drm-misc?
>
> Of course,
> Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

Thanks for the Ack.

I didn't get an ack from Rockchip, but still going ahead with
the push since it's been a while and the change is very minor.

Thanks,
Archit

> regards
> Philipp

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project