Re: [PATCH v3 06/17] mfd: madera: Register map tables for Cirrus Logic CS47L90/91

[Lee Jones]

On Fri, 02 Jun 2017, Richard Fitzgerald wrote:

> Regmap configuration tables for Cirrus Logic CS47L90 and CS47L91 codecs.
> 
> Signed-off-by: Nikesh Oswal <nikesh@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> No changes since V2
> 
>  drivers/mfd/Kconfig          |    7 +
>  drivers/mfd/Makefile         |    3 +
>  drivers/mfd/cs47l90-tables.c | 2830 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 2840 insertions(+)
>  create mode 100644 drivers/mfd/cs47l90-tables.c
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6f83316..a59f488 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -242,6 +242,13 @@ config MFD_CS47L85
>  	help
>  	  Support for Cirrus Logic CS47L85 Smart Codec
>  
> +config MFD_CS47L90
> +	bool "Cirrus Logic CS47L90/91"
> +	select PINCTRL_CS47L90
> +	depends on MFD_MADERA
> +	help
> +	  Support for Cirrus Logic CS47L90 and CS47L91 Smart Codecs
> +
>  config MFD_ASIC3
>  	bool "Compaq ASIC3"
>  	depends on GPIOLIB && ARM
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index e522774..57ea34e 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -79,6 +79,9 @@ endif
>  ifeq ($(CONFIG_MFD_CS47L85),y)
>  obj-$(CONFIG_MFD_MADERA)	+= cs47l85-tables.o
>  endif
> +ifeq ($(CONFIG_MFD_CS47L90),y)
> +obj-$(CONFIG_MFD_MADERA)	+= cs47l90-tables.o
> +endif
>  obj-$(CONFIG_MFD_MADERA_I2C)	+= madera-i2c.o
>  obj-$(CONFIG_MFD_MADERA_SPI)	+= madera-spi.o
>  
> diff --git a/drivers/mfd/cs47l90-tables.c b/drivers/mfd/cs47l90-tables.c
> new file mode 100644
> index 0000000..52ce50f
> --- /dev/null
> +++ b/drivers/mfd/cs47l90-tables.c
> @@ -0,0 +1,2830 @@
> +/*
> + * Regmap tables for CS47L90 codec
> + *
> + * Copyright 2015-2016 Cirrus Logic

This is out of date.

Besides that and the fact that H/W patches SUCK:

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>

[...]

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog