Re: [PATCH v4 2/2] clk: at91: Add sama5d2 suspend/resume

[Alexandre Belloni]

Hi,

On 01/06/2017 at 00:46:44 -0700, Stephen Boyd wrote:
> > +
> > +static u8 registered_ids[PMC_MAX_IDS];
> > +
> > +void pmc_register_id(u8 id)
> > +{
> 
> Shouldn't this also be inside CONFIG_PM? And then
> pmc_register_id() is a nop function when CONFIG_PM=n?
> 

I'll do that. I'll rebase on top of clk-next once you fix my silly
mistake.

> > +	int i;
> > +
> > +	for (i = 0; i < PMC_MAX_IDS; i++) {
> > +		if (registered_ids[i] == 0) {
> > +			registered_ids[i] = id;
> > +			break;
> > +		}
> > +		if (registered_ids[i] == id)
> > +			break;
> > +	}
> > +}
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com