Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API

From: Christoph Hellwig
Date: Mon Jun 05 2017 - 12:01:55 EST


> - if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
> - CPER_SEC_PLATFORM_MEM)) {
> + if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {

The "!" here seems incorrect.

> #ifdef CONFIG_ACPI_APEI_PCIEAER
> - else if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
> - CPER_SEC_PCIE)) {
> + else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) {

Same here.