Re: [PATCH v4 5/8] nvme: get list of namespace descriptors

[Sagi Grimberg]

On 05/06/17 08:38, Christoph Hellwig wrote:
> > +			}
> > +			len = NVME_NIDT_UUID_LEN;
> > +			memcpy(ns->uuid, data + pos + sizeof(*cur), len);
> > +			break;
> > +		default:
> > +			dev_warn(ns->ctrl->dev,
> > +				 "Invalid Namespace Identification Descriptor Type: %d\n",
> > +				 cur->nidt);
> > +			return;
>
> Please drop the warning and return, the spec says hosts should ignore
> unknown types.  This is important to future proof for new types that
> could be added.

Also, please stay consistent with the rest of the driver by logging the
correct device prefix using ctrl->device and not ctrl->dev.

(if we have some ctrl->dev left-overs, can you also send a patch to fix?)