Re: [PATCH 2/6] perf/x86: Fix data source decoding for Skylake

From: Andi Kleen
Date: Tue Jun 06 2017 - 09:51:41 EST


> Not too happy about that..
>
> P(LVLX, L4) | P(LVLX, REMOTE)
>
> reads like something that should be PERF_MEM_LVL_REM_CCE1 or something

CCE1? You mean L4?

The two bits seem cleaner to me than enumerating all cases. But ok.

REM_L4


> This new generic 'REMOTE' has too much overlap with the existing things.

So you want a REM_NA ?

-Andi